adding functionality for including a named graph in output#27
Open
pwin wants to merge 1 commit into
Open
Conversation
|
CodeAnt AI is reviewing your PR. |
Review Summary by Qodo
WalkthroughsDescription• Add optional --graph argument to enable N-Quads output format • Convert internal triple storage to quads with named graph support • Conditionally apply graph name to quads based on CLI argument • Remove 366 lines of unit tests from main library file • Simplify CLI help text and code formatting throughout Diagramflowchart LR
A["CSV Input"] --> B["Reader Thread"]
B --> C["Transformer Thread"]
C --> D["Triple Generation"]
D --> E{"Graph IRI<br/>Provided?"}
E -->|Yes| F["Wrap in Quad<br/>with Named Graph"]
E -->|No| G["Wrap in Quad<br/>with Default Graph"]
F --> H["N-Quads Output"]
G --> H
H --> I["Output File/STDOUT"]
File Changes1. src/lib.rs
|
Code Review by Qodo
1. Graph IRI unwrap panic
|
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
codeant-ai
Bot
added
the
size:L
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+167
to
+170
| let g = if let Some(ref iri) = graph_name { | ||
| NamedNode::new(iri.clone()).unwrap().into() | ||
| } else { | ||
| GraphName::DefaultGraph |
There was a problem hiding this comment.
1. Graph iri unwrap panic 🐞 Bug ☼ Reliability
When --graph is provided, the writer thread calls NamedNode::new(graph_iri).unwrap() for every produced triple; an invalid/empty graph IRI will panic the writer thread and abort the transform. The CLI/config layer stores --graph as an unvalidated Option<String>, so this panic is reachable via normal user input.
Agent Prompt
### Issue description
`--graph` is accepted as a raw string and later converted to a `NamedNode` using `.unwrap()` inside the writer loop. If the user provides an invalid IRI (including `--graph=`), the writer thread panics and the whole transformation fails with a thread panic instead of a clean error.
### Issue Context
- `parse_args()` defines `--graph` as a free-form string.
- `configure_transform()` stores it as `Option<String>` without validation.
- `transform()` converts it to `NamedNode` with `unwrap()` inside the per-triple loop.
### Fix
- Validate and parse `--graph` once (during `configure_transform()` or at the start of `transform()`), returning a normal `Err` with a helpful message if invalid.
- Store the parsed value as `Option<NamedNode>` or `Option<GraphName>` (or precomputed `GraphName`) so the writer loop does not repeatedly parse/clone.
- Replace `unwrap()` in the writer loop with precomputed value usage (or proper error propagation if you keep parsing there).
### Fix Focus Areas
- src/lib.rs[144-190]
- src/lib.rs[549-605]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| .unwrap(); | ||
| for t in row_triples { | ||
| let g = if let Some(ref iri) = graph_name { | ||
| NamedNode::new(iri.clone()).unwrap().into() |
There was a problem hiding this comment.
Suggestion: The graph IRI is parsed with unwrap() inside the writer thread, so an invalid --graph value will panic at runtime instead of returning a normal error. Validate/parse the graph IRI once before spawning workers and propagate a proper Result error instead of panicking. [possible bug]
Severity Level: Major ⚠️
- ❌ Invalid --graph input crashes program instead of failing gracefully.
- ⚠️ Harder to diagnose user errors in graph IRI.Steps of Reproduction ✅
1. Run the compiled `oxi_gen` binary (`src/main.rs:4-14`) with a `--graph` argument that
is not a valid absolute IRI, for example: `oxi_gen --query
tests/fixtures/optional_field.rq --input tests/fixtures/optional_field.csv --output STDOUT
--graph not-a-valid-iri`.
2. `parse_args` in `src/lib.rs:37-166` defines the `graph` option (lines 158-163) as a
free-form string with no validation, and `configure_transform` (`src/lib.rs:168-205`)
assigns `graph: matches.get_one::<String>("graph").cloned()`, so `OxiGen.graph` becomes
`Some("not-a-valid-iri".to_string())`.
3. Inside `OxiGen::transform` (`src/lib.rs:47-274`), the value is cloned into `graph_name`
at line 140 and moved into the writer thread (spawned at line 144); when triples arrive on
`triple_rx`, the writer computes a graph name with `let g = if let Some(ref iri) =
graph_name { NamedNode::new(iri.clone()).unwrap().into() } else { GraphName::DefaultGraph
};` (`src/lib.rs:167-170`).
4. For the invalid `iri` string, `NamedNode::new(iri.clone())` returns `Err`, and the
`.unwrap()` at line 168 panics inside the writer thread; `transform` later detects this
via `writer_task.join()` and returns `Err("Writer thread panicked".into())`
(`src/lib.rs:258-261`), which causes `main` to panic on
`transform.transform().expect("Transformation failed")` (`src/main.rs:11`), terminating
the process instead of returning a normal, descriptive error about the bad `--graph`
value.Fix in Cursor | Fix in VSCode Claude
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** src/lib.rs
**Line:** 168:168
**Comment:**
*Possible Bug: The graph IRI is parsed with `unwrap()` inside the writer thread, so an invalid `--graph` value will panic at runtime instead of returning a normal error. Validate/parse the graph IRI once before spawning workers and propagate a proper `Result` error instead of panicking.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
|
CodeAnt AI finished reviewing your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
cargo test --test main -- --nocapture
to print the quads. SPOG.
I haven't checked that this returns gzip
CodeAnt-AI Description
Add named graph output with N-Quads support
What Changed
--graphoption so output can include a named graph IRIImpact
✅ Can write named-graph data✅ N-Quads output for graph-aware exports✅ Clearer command-line usage for graph output💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.