feat: Stackbit 1248 camera scanner#839
Conversation
Add camera-based scanner for Stackbit 1248 metal backup plates. Reads punched dots and decodes BIP39 words automatically. Supports 12/24 word mnemonics and both 1248 and 1248mini plates.
|
Nice @stackbitme! To move on, the PR needs several adjusts to pass tests, I would start with format and linting, then you need to add translations, fix existing tests, and create new ones to cover the added feature. |
|
Hey @odudex, have you tested the PR first? I think it’s better to review the functionality and implementation upfront. If it looks good, then add tests, otherwise @stackbitme may have to redo them after further changes. |
|
Every |
- Format code with black - Fix pylint warnings (unused imports, naming, unnecessary else) - Add translations for 7 new strings in all 11 languages - Fix 3 broken mnemonic_xor tests (menu index shift from new Stackbit item) - Revert unneeded imports added to stack_1248.py
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.20%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #839 +/- ##
===========================================
- Coverage 97.31% 92.95% -4.36%
===========================================
Files 83 84 +1
Lines 10573 11078 +505
===========================================
+ Hits 10289 10298 +9
- Misses 284 780 +496 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
How is this PR going? If you need help, please ask and I'll gladly to give you a hand, plus I think we have a commit waiting for approval right? |
|
@stackbitme, are you alive? |
|
@stackbitme im working on features similar to this, if you need some help, we can hand it together. |
|
@stackbitme , need to test some function and cover them to continue. |
Summary
Added a camera scanner for Stackbit 1248 metal backup plates. It reads the punched dots and decodes the BIP39 words automatically.
Works with both 12 and 24 word mnemonics, and supports standard 1248 and 1248mini plates.
How to use
Test plan