Conversation
Note: Updates don't quite work yet.
|
Tested on build Second Life Project One-click 26.1.0.20387239236 Test plan provided to QA:
I verified on Windows machine that the build installs with one click to [user]/AppData/Local and after install the viewer launches and runs successfully. Viewer is installed Second Life Project One-Click I verified that the app can be removed in the add/remove apps section and the viewer is deleted and leaves behind a SecondLifeProjectOne-Click folder in [user]/AppData/Local containing just 2 files .dead and velopack (log?) I verified you could successfully relaunch the app from the desktop icon and from the App list on the start menu. I verified the Mac build installs on Mac the same way current release viewer does successfully Issues noticed in testing.
So in the spirit of wanting to get the one click install to get user feedback this seems to be meet those goals but the issues should be identified in the release notes to help out the users trying it out. Passed QA based on test plan provided and goals of this release. |
|
Per discussion with grumpity, to make a good first impression with this the updater issues should be addressed before release. |
indra/newview/llvelopack.cpp
Outdated
|
|
||
| static const wchar_t* PROTOCOL_SECONDLIFE = L"secondlife"; | ||
| static const wchar_t* PROTOCOL_GRID_INFO = L"x-grid-location-info"; | ||
| static const wchar_t* VIEWER_EXE_NAME = L"SecondLifeViewer.exe"; |
There was a problem hiding this comment.
This to me seems unnecessary to hardcode the viewer exe name when it can be obtained from gDirUtilp->getExecutableFilename() and then use ll_convert<std::wstring>, since LLDir_Win32 will have been constructed already before WINMAIN has been called.
This would allow for better compatibility with TPV's so they don't all need to change this hardcoded constant to work with Velopack.
For sanity sake, I tested with my development build of Firestorm and after it ran the Velopack installer, inside on_after_install using gDirUtilp->getExecutableFilename() returned the correct exe name, the viewer worked correctly and the installer setup the shortcuts and protocols correctly too.
NOTES Anti-virus false positive report:
|
kylelinden
left a comment
There was a problem hiding this comment.
One Click Install Alpha approved
viewer = 26.1.0.21295806042
build = https://github.com/secondlife/viewer/releases/tag/Second_Life_Project%2385298ebb-OneClickInstall
cohort = One Click Install
desired = 0
| register_protocol_handler(PROTOCOL_SECONDLIFE, L"URL:Second Life", exe_path); | ||
| register_protocol_handler(PROTOCOL_GRID_INFO, L"URL:Second Life", exe_path); | ||
| register_uninstall_info(install_dir, app_name, version); | ||
| create_shortcuts(install_dir, app_name); |
There was a problem hiding this comment.
Velopack already creates both the Desktop and Start Menu shortcuts based on the app name given to the --packTitle argument in the vpk call, it also uninstalls them for you as well.
So calling create_shortcuts here and the remove_shortcuts a little further below to do them manually, seems redundant?
The only difference I noticed, is that Velopack by default doesn't put the start menu shortcut inside of it's own folder, but the desktop shortcut is the same. Which also means, currently the installer creates two different start menu shortcuts (one in Start Menu\Programs\Second Life Test, the other just in Start Menu\Programs)
The velopack start menu shortcut location can be changed with the --shortcuts argument in the vpk call.
as of = 2026-01-26 for PV deploy
build = https://github.com/secondlife/viewer/releases/tag/Second_Life_Project%2385298ebb-OneClickInstall
cohort = One Click Install
deployed = https://github.com/secondlife/viewer/releases/tag/Second_Life_Project%2385298ebb-OneClickInstall
desired = 0
relnotes:
One Click Install Alpha Viewer
Hey everyone!
This release we have the One Click Install Alpha Viewer. This is an early alpha release to streamline the experience of setting up the viewer on Windows computers and getting in world. This also will help ease the update process for viewers moving forward.
What's different
--installtocommand line parameterAt present, you will have two viewers installed: the one click viewer and the current viewer. This is expected, and will be improved in a future alpha.