[Hipblaslt] Subtile/TDM (gfx1250): load dedup, multi-partition LDS fix, WMMA matrix-A reuse#7
Conversation
The subtile TDM path split each tensor's global load only across its own wave axis (mt/numWavesThisAxis), so waves sharing an axis id re-issued bit-identical tensor_load_to_lds (same global source + same LDS dest). Split across the full wave count (mt/numWaves) instead, in all three coordinated sites: global address, LDS write offset, and descriptor tile1 extent. The global->LDS mapping stays identity, so the local-read consumer is unchanged; cross-wave LDS visibility is covered by the existing WaitGROp(has_sync) barrier before local reads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtile/TDM (gfx1250): load dedup, multi-partition LDS fix, WMMA matrix-A reuse
Changes