Monitoring fix#231
Merged
Merged
Conversation
Enhance Docker and host monitoring with Prometheus and Grafana configuration
Enables Prometheus to collect host metrics from cadvisor and node_exporter by running as root, ensuring it can access the Docker socket. Removes commented-out user configuration to clarify intent.
marcpaget
requested review from
AdamBdamCdam,
AsgerT10,
Jacob-Sonne,
mekererenate-web and
sebsthiel
|
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run Prometheus as root in docker-compose.monitoring.yml as it is (seemingly) the only way to access docker socket and host metrics from cadvisor and node_exporter