Feature/metrics exporter#226
Conversation
Looks good !
Develop into main
Removed global deployment mode for the service. This is removed in prod
…d add labels for cAdvisor and Node Exporter services
Configures persistent storage and port mapping for Prometheus, updates scrape targets for web and API components, and exposes Grafana via nginx for easier access. Enhances monitoring by simplifying service discovery and enabling better local testing. Co-authored-by: Copilot <copilot@github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
| - prometheus-storage:/prometheus | ||
| - /var/run/docker.sock:/var/run/docker.sock | ||
| ports: | ||
| - "9090:9090" |
There was a problem hiding this comment.
Why do we need to expose the port?
There was a problem hiding this comment.
We don't actually, it's a leftover from local testing - can safely be removed/commented out
| # proxy_set_header Upgrade $http_upgrade; | ||
| # proxy_set_header Connection "upgrade"; | ||
| # } | ||
| location /grafana { |
There was a problem hiding this comment.
Monitoring is not deployed locally be default. So i think it should be a comment. Else nginx will fail locally
|
Could you also add the grafana dashboard that use these metrics to the pr? |
Comment out the grafana location block and proxy_pass directive.
Comment out Grafana proxy settings in Nginx config
Comment out the ports section for Prometheus service.
|
3 participants
No description provided.