Fix object comparison#70
Open
vinicius-lino-figueiredo wants to merge 1 commit into
Open
Conversation
Make model.compareThings actually work for objects. Before, any docs
with same values (not keys) and length would count as equal
(like {a: 1} and {b: 1}) and that would make index throw an unexpected
constraint violation error for some specific cases.
343b6eb to
30d2a23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make model.compareThings actually work for objects; model.compareThings would
only check field values and object length, ignoring object keys. Now it works
for those specific cases where it would not before.
In this code:
the second insert would return an error, when comparing {one:1} and {another:1},
the old function would:
are equal too).
Now, if length comparison does not return a difference, we compare the key list.