Fix stack overflow#53
Open
chrismwendt wants to merge 1 commit into
Open
Conversation
|
This fix makes a lot of sense as there's no need to push to an empty array when you can just reassign it. Just thinking on optimizations it makes a lot of sense. How is it going @tex0l @arantes555 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces a spread call
validDocs.push(...docs)wherevalidDocswas empty with simple assignmentvalidDocs = docsto avoid a stack overflow with a bigdocsarray.Spread calls use stack space, so
foo.push(...REALLY_BIG_ARRAY)uses LOTS of stack space and it can easily cause a stack overflow.