rust: update target jsons for rustc 1.93+#421
Open
zaklogician wants to merge 1 commit intoseL4:mainfrom
Open
Conversation
Recent versions of `rustc` expect the `target-pointer-width` field in `target.json` files to hvae type `u16` instead of `string`. The target specifications under `example/rust` and `initialiser` still use the older format, which results in errors when running `build_sdk.py` on a system with newer `rustc` versions. Here we update these files to the newer format, which makes the build succeed on `rustc` 1.93.0 and above. NB this commit does not add condition logic / multiple copies to support multiple incompatible versions of these json files, so the build will now fail with outdated versions of `rustc` instead. Signed-off-by: Zoltan A. Kocsis <11808286+zaklogician@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent versions of
rustcexpect thetarget-pointer-widthfield intarget.jsonfiles to have typeu16instead ofstring(see Rust PR# 144443).Our target specifications under
example/rustandinitialiserstill use the older format, which results in errors when running./pyenv/bin/python build_sdk.pyon a system with a newer version ofrustc.Here we update these files to the newer format, which makes the build succeed on
rustc1.93.0 and above.NB this commit does not add condition logic / multiple copies to support multiple incompatible versions of these json files, so the build will now fail with outdated versions of
rustcinstead.