Docker container now runs 'yamllint' on entry.#2
Open
housni wants to merge 1 commit intosdesbure:masterfrom
Open
Docker container now runs 'yamllint' on entry.#2housni wants to merge 1 commit intosdesbure:masterfrom
housni wants to merge 1 commit intosdesbure:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for creating this repo. I'm using it for checking my Travis YAML file for Sheldon: https://github.com/housni/Sheldon/blob/cleanup/Makefile#L244
My PR does the following:
WORKDIRfrom Dockerfile. It makes more sense to mount it on a Docker run so that we can specify the directory mount dir and the workdir and not have to worry about mapping to/yaml.ENTRYPOINTwith theyamllintexecutable so that, in adocker run, you can just pass the file names into the container andyamllintwill run against them. Failure to provide file names will result inyamllint --versionbeing run (default).README.mdcontents to reflect the changes mentioned above.