[codex] Add indicator cache invalidation#63
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebfe0d10f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if !ok { | ||
| return false |
There was a problem hiding this comment.
Reset all built-in cached indicators
When callers use this new helper with NewMMAIndicator(...), it returns false here even though modifiedMovingAverageIndicator has a resultCache and uses returnIfCached/cacheResult, so changing an underlying candle leaves previously calculated MMA values stale with no invalidation path short of rebuilding the indicator. Since resetResultCache already accepts the shared cachedIndicator interface, the helper should also handle cached indicators that don't add their own CacheResetter method.
Useful? React with 👍 / 👎.
0cde7f9 to
376ccd8
Compare
ebfe0d1 to
21d5174
Compare
[codex] Make indicator test helper vet-safe
[codex] Harden analysis edge cases
[codex] Document indicator warm-up behavior
Summary
Related issues
Addresses #53.
Validation
Stacked on #62.