Skip to content

[codex] Upgrade module to Go 1.21#60

Merged
sdcoffey merged 18 commits into
mainfrom
codex/go-1.21
May 29, 2026
Merged

[codex] Upgrade module to Go 1.21#60
sdcoffey merged 18 commits into
mainfrom
codex/go-1.21

Conversation

@sdcoffey

@sdcoffey sdcoffey commented May 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • raise the module's declared Go version from 1.12 to 1.21
  • tidy module metadata with the Go 1.26.3 toolchain
  • remove the old Travis CI config that still targeted Go 1.15
  • add a GitHub Actions test workflow that uses the Go version from go.mod

Validation

  • GOCACHE=/private/tmp/techan-gocache mise x go@1.26.3 -- go test ./...
  • GOCACHE=/private/tmp/techan-gocache mise x go@1.26.3 -- go test -race -cover -covermode=atomic -coverprofile=coverage.txt github.com/sdcoffey/techan

@sdcoffey sdcoffey marked this pull request as ready for review May 29, 2026 15:28
@sdcoffey

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00912e53e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread go.mod
module github.com/sdcoffey/techan

go 1.12
go 1.21

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep CI toolchain compatible with module minimum

The repo’s checked CI config still runs Travis with Go 1.15 (.travis.yml lines 3-10), but this change declares the module’s minimum as Go 1.21. The Go module reference says the go directive is now a mandatory requirement and toolchains refuse modules declaring newer Go versions, so the existing go get/make test-with-coverage job will fail before tests run whenever Travis uses its configured 1.15 toolchain. Please update the CI Go version to 1.21+ in the same change, or keep the directive compatible with the configured CI toolchain.

Useful? React with 👍 / 👎.

@sdcoffey sdcoffey merged commit ddfe3f9 into main May 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant