[codex] Upgrade module to Go 1.21#60
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00912e53e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| module github.com/sdcoffey/techan | ||
|
|
||
| go 1.12 | ||
| go 1.21 |
There was a problem hiding this comment.
Keep CI toolchain compatible with module minimum
The repo’s checked CI config still runs Travis with Go 1.15 (.travis.yml lines 3-10), but this change declares the module’s minimum as Go 1.21. The Go module reference says the go directive is now a mandatory requirement and toolchains refuse modules declaring newer Go versions, so the existing go get/make test-with-coverage job will fail before tests run whenever Travis uses its configured 1.15 toolchain. Please update the CI Go version to 1.21+ in the same change, or keep the directive compatible with the configured CI toolchain.
Useful? React with 👍 / 👎.
[codex] Make indicator test helper vet-safe
[codex] Harden analysis edge cases
[codex] Document indicator warm-up behavior
[codex] Add indicator cache invalidation
[codex] Guard trendline slope for sparse windows
[codex] Fix stop-loss price basis
Summary
Validation