Skip to content

[codex] Fix decimal correctness and maintenance issues#9

Merged
sdcoffey merged 13 commits into
mainfrom
codex-fix-decimal-review-findings
May 29, 2026
Merged

[codex] Fix decimal correctness and maintenance issues#9
sdcoffey merged 13 commits into
mainfrom
codex-fix-decimal-review-findings

Conversation

@sdcoffey

@sdcoffey sdcoffey commented May 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Preserve precision when constructing, formatting, and combining decimal values.
  • Normalize zero-value and NaN handling across arithmetic, JSON, SQL, and comparisons.
  • Handle invalid math cases such as negative square roots and negative powers.
  • Reduce internal dependence on mutable exported sentinels.
  • Update github.com/stretchr/testify to v1.11.1.
  • Pin Makefile tool installs, stop make test from rewriting files, and harden release tag detection.
  • Clarify README semantics for the math/big.Float-backed implementation.

Commit Structure

Each review finding/fix area is split into its own commit for easier review.

Validation

  • mise exec go@1.26.3 -- go test ./...
  • bash -n scripts/release.sh
  • Confirmed GitHub Actions Tests matrix passes on Go 1.21, 1.22, 1.23, 1.24, 1.25, and 1.26.

@sdcoffey sdcoffey marked this pull request as ready for review May 29, 2026 16:18

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84550ec737

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread decimal.go Outdated
Comment thread decimal.go Outdated
@sdcoffey sdcoffey merged commit a6f1f87 into main May 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant