Refactor UDP communication out into transport class#35
Open
dannyZyg wants to merge 1 commit intoscztt:developfrom
Open
Refactor UDP communication out into transport class#35dannyZyg wants to merge 1 commit intoscztt:developfrom
dannyZyg wants to merge 1 commit intoscztt:developfrom
Conversation
Extracts all UDP specific functionality into a transport class that could be swapped out for stdio, or anything else.
dannyZyg
commented
Apr 6, 2026
Comment on lines
+89
to
+96
| Routine({ | ||
| this.transport.start(this); | ||
|
|
||
| // @TODO Is this the only "default" provider we want? | ||
| this.addProvider(InitializeProvider(this, {})); | ||
|
|
||
| readyMsg.postln; | ||
| }).play(AppClock); |
Author
There was a problem hiding this comment.
Is there a preferred approach here? This is blocking as I understand, which could be a problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts all UDP specific functionality into a transport class that could be swapped out for stdio, or anything else.
As mentioned in your comment here, it would be great for sclang to support stdio for LSP.
I've been looking into sclang stdio compatibility for LSP usage, and while there are a bunch of things to consider on the sclang side, this might be the small first step towards compatibility on the quark side of things.
A couple of chunks that would need to be completed:
If this is completely off the mark please let me know and I'd be happy to have another crack at it.