Open
Conversation
Since engines not supporting bigint are long deprecated, this commit removes some logic in encoder aimed at supporting those engines
There was a problem hiding this comment.
Pull request overview
This PR modernizes the encoder implementation by removing legacy BigInt compatibility logic for deprecated Node.js engines and by improving JSDoc type annotations to support the gradual TypeScript migration discussed in #350.
Changes:
- Removed runtime BigInt support detection and switched to BigInt literals / direct
32nand8nshifts. - Added/expanded JSDoc annotations (
@param,@returns,@private) across many encode/decode helpers. - Minor JSDoc cleanups and return type documentation updates.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wprzytula
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes removal of logic for deprecated node engines and type annotations improvements (necessary for #350)