Skip to content

refactor(external): share cyclic loader for GIMVI and DIAGVI#3830

Open
ori-kron-wis wants to merge 1 commit into
mainfrom
Ori-gimvi-diagvi-shared-code-blocks
Open

refactor(external): share cyclic loader for GIMVI and DIAGVI#3830
ori-kron-wis wants to merge 1 commit into
mainfrom
Ori-gimvi-diagvi-shared-code-blocks

Conversation

@ori-kron-wis
Copy link
Copy Markdown
Collaborator

No description provided.

@ori-kron-wis ori-kron-wis self-assigned this Jun 2, 2026
@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.4.x on-merge: backport to 1.4.x label Jun 2, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

❌ Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.52%. Comparing base (4e03ff9) to head (57b69ff).

Files with missing lines Patch % Lines
src/scvi/external/gimvi/_task.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3830      +/-   ##
==========================================
- Coverage   88.53%   88.52%   -0.01%     
==========================================
  Files         237      237              
  Lines       23827    23827              
==========================================
- Hits        21095    21094       -1     
- Misses       2732     2733       +1     
Flag Coverage Δ
integration 72.60% <96.87%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scvi/external/diagvi/_model.py 92.17% <100.00%> (-0.26%) ⬇️
src/scvi/external/gimvi/_model.py 92.12% <100.00%> (-0.42%) ⬇️
src/scvi/external/gimvi/_task.py 96.15% <96.15%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on-merge: backport to 1.4.x on-merge: backport to 1.4.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant