Fix pandas 3 data type and copy/write bugs#436
Merged
grst merged 2 commits intoscverse:mainfrom Jan 23, 2026
Merged
Conversation
grst
approved these changes
Jan 23, 2026
Collaborator
grst
left a comment
There was a problem hiding this comment.
LGTM, I have two unrelated comments -- not necessary to fix in this PR.
Collaborator
Author
Thanks! Agree with the proposed changes, but outside the scope of what I can allocate time to this week. Since it's currently broken with pandas 3, probably best to raise an issue for these points for a follow up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
See: https://scverse.zulipchat.com/#narrow/channel/316218-repo-management/topic/Upcoming.20Pandas.203.2E0.2E0.20release/with/569443597
What does your PR implement? Be specific.
Fixes pandas 3 (now released) incompatibility due to bool to float conversion & update on copy of DataFrame errors as well as explicit keyword arguments on mean/sum.
.sum(0)/.mean(0)/.sum()/.mean()to `.sum(axis=0)/.mean(axis=0)