Skip to content

Page #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scriptor-pro merged 2 commits into from
Jan 16, 2026
Merged

Page #1

scriptor-pro merged 2 commits into from
Jan 16, 2026

Conversation

@scriptor-pro
Copy link
Owner

@scriptor-pro scriptor-pro commented Jan 16, 2026

No description provided.

@scriptor-pro
Add GitHub Pages Jekyll site
3c3b57e 
- Create Jekyll static site structure with bilingual support (FR/EN)
- Add responsive design with app's color scheme
- Include features section, installation methods, keyboard shortcuts
- Add GitHub Actions workflow for automatic deployment
- Copy screenshots and background assets
- Implement language switcher with localStorage persistence
- Add download links and contribution section
@scriptor-pro
Fix GitHub Pages build settings
f46ed00 
Set baseurl for project site and clarify that Pages must use GitHub Actions
@scriptor-pro scriptor-pro requested a review from Copilot January 16, 2026 16:37
@scriptor-pro scriptor-pro self-assigned this Jan 16, 2026
@scriptor-pro scriptor-pro merged commit aa75364 into main Jan 16, 2026
5 of 6 checks passed
Copilot AI reviewed Jan 16, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request creates a comprehensive GitHub Pages website for the Clarionet project, transforming the previous standalone HTML page into a full Jekyll-based site with bilingual support (French/English).

Changes:

  • Replaces standalone HTML files with a Jekyll-based GitHub Pages site
  • Implements bilingual support with client-side language switcher
  • Adds comprehensive styling with dark theme matching the app's color scheme
  • Includes GitHub Actions workflow for automated deployment

Reviewed changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
page/index.md Main landing page with hero section, features, installation methods, keyboard shortcuts, philosophy, and download sections
page/_layouts/default.html Base HTML layout template with header and footer includes
page/_layouts/page.html Page layout wrapper
page/_includes/header.html Site header with logo, navigation, and language switcher
page/_includes/head.html HTML head with meta tags and stylesheets
page/_includes/footer.html Site footer with links and copyright
page/_includes/features.html Features grid component
page/assets/css/style.scss Complete stylesheet with dark theme and responsive design
page/_config.yml Jekyll configuration with site settings and metadata
.github/workflows/pages.yml GitHub Actions workflow for automated Jekyll deployment
page/Gemfile Ruby dependencies specification
page/README.md Documentation for the Pages site structure and development

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

page/index.md
Comment on lines +119 to +154
<th class="fr">Touche</th>
<th class="en">Key</th>
<th class="fr">Action</th>
<th class="en">Action</th>
</tr>
</thead>
<tbody>
<tr>
<td><kbd>Space</kbd></td>
<td class="fr">Lecture / Pause</td>
<td class="en">Play / Pause</td>
</tr>
<tr>
<td><kbd>S</kbd></td>
<td class="fr">Arrêt</td>
<td class="en">Stop</td>
</tr>
<tr>
<td><kbd>←</kbd> / <kbd>→</kbd></td>
<td class="fr">Volume − / +</td>
<td class="en">Volume − / +</td>
</tr>
<tr>
<td><kbd>↑</kbd> / <kbd>↓</kbd></td>
<td class="fr">Station précédente / suivante</td>
<td class="en">Previous / Next station</td>
</tr>
<tr>
<td><kbd>Ctrl</kbd> + <kbd>N</kbd></td>
<td class="fr">Ajouter une radio</td>
<td class="en">Add a radio</td>
</tr>
<tr>
<td><kbd>Ctrl</kbd> + <kbd>Q</kbd></td>
<td class="fr">Quitter</td>
<td class="en">Quit</td>
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shortcuts table has incorrect structure. The table header has two rows (lines 119-122) but they should be a single header row. Additionally, the data cells (td) are placed in column positions that don't match the structure - the key should be in the first column, and the action should be in the second column for both languages.

Suggested change
<th class="fr">Touche</th>
<th class="en">Key</th>
<th class="fr">Action</th>
<th class="en">Action</th>
</tr>
</thead>
<tbody>
<tr>
<td><kbd>Space</kbd></td>
<td class="fr">Lecture / Pause</td>
<td class="en">Play / Pause</td>
</tr>
<tr>
<td><kbd>S</kbd></td>
<td class="fr">Arrêt</td>
<td class="en">Stop</td>
</tr>
<tr>
<td><kbd>←</kbd> / <kbd>→</kbd></td>
<td class="fr">Volume − / +</td>
<td class="en">Volume − / +</td>
</tr>
<tr>
<td><kbd>↑</kbd> / <kbd>↓</kbd></td>
<td class="fr">Station précédente / suivante</td>
<td class="en">Previous / Next station</td>
</tr>
<tr>
<td><kbd>Ctrl</kbd> + <kbd>N</kbd></td>
<td class="fr">Ajouter une radio</td>
<td class="en">Add a radio</td>
</tr>
<tr>
<td><kbd>Ctrl</kbd> + <kbd>Q</kbd></td>
<td class="fr">Quitter</td>
<td class="en">Quit</td>
<th>
<span class="fr">Touche</span>
<span class="en">Key</span>
</th>
<th>
<span class="fr">Action</span>
<span class="en">Action</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<td><kbd>Space</kbd></td>
<td>
<span class="fr">Lecture / Pause</span>
<span class="en">Play / Pause</span>
</td>
</tr>
<tr>
<td><kbd>S</kbd></td>
<td>
<span class="fr">Arrêt</span>
<span class="en">Stop</span>
</td>
</tr>
<tr>
<td><kbd>←</kbd> / <kbd>→</kbd></td>
<td>
<span class="fr">Volume − / +</span>
<span class="en">Volume − / +</span>
</td>
</tr>
<tr>
<td><kbd>↑</kbd> / <kbd>↓</kbd></td>
<td>
<span class="fr">Station précédente / suivante</span>
<span class="en">Previous / Next station</span>
</td>
</tr>
<tr>
<td><kbd>Ctrl</kbd> + <kbd>N</kbd></td>
<td>
<span class="fr">Ajouter une radio</span>
<span class="en">Add a radio</span>
</td>
</tr>
<tr>
<td><kbd>Ctrl</kbd> + <kbd>Q</kbd></td>
<td>
<span class="fr">Quitter</span>
<span class="en">Quit</span>
</td>

Copilot uses AI. Check for mistakes.
page/_includes/header.html
Comment on lines +56 to +66
if (lang === 'fr') {
allFr.forEach(el => el.style.display = '');
allEn.forEach(el => el.style.display = 'none');
document.documentElement.lang = 'fr';
localStorage.setItem('clarionet-lang', 'fr');
} else {
allFr.forEach(el => el.style.display = 'none');
allEn.forEach(el => el.style.display = '');
document.documentElement.lang = 'en';
localStorage.setItem('clarionet-lang', 'en');
}
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The language switcher script uses inline styles to hide/show elements by setting the display property directly. This approach can cause conflicts with CSS and makes the code harder to maintain. Consider using CSS classes instead to toggle visibility.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@scriptor-pro scriptor-pro

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scriptor-pro