suggested improvements to gulpfile.js#29
Open
iavasquez wants to merge 1 commit intoscotch-io:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for writing mean-machine. Read it and really found it useful. I used your gulpfile to create my own build workflow. In doing so, I noticed some issues / areas for improvement that I wanted to suggest to you. In order of appearance in the gulpfile:
Use jshint-stylish lint reporter for better readability of jshint. You already had it in your dev-dependencies but weren't using it in the gulpfile.
Split jshint tasks into separate server-side and client-side js tasks in order to use different options for error reporting ( node: true for server side js, browser: true for client side js)
Nodemon task as written didn't work for me. I think the issue is that it was redundant to call the watch task from nodemon on events. Nodemon is already watching the file extensions specified and restarting every time there is an update. If you want nodemon to call tasks on restart, you can simply specify those in the "tasks" element of the options object.