Skip to content

Onboard to distgen#380

Draft
ndavidova wants to merge 7 commits into
masterfrom
ndavidov/distgen
Draft

Onboard to distgen#380
ndavidova wants to merge 7 commits into
masterfrom
ndavidov/distgen

Conversation

@ndavidova
Copy link
Copy Markdown

@ndavidova ndavidova commented May 18, 2026 •
edited by github-actions Bot
Loading

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9272955e-9ce3-4c20-ae70-63facee09d7a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ndavidov/distgen

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026 •
edited
Loading

Pull Request validation

Failed

🔴 Failed or pending statuses:

  • Testing Farm - Fedora - 1.26[error]
  • Testing Farm - CentOS Stream 10 - 1.26[error]
  • Testing Farm - CentOS Stream 9 - 1.24[error]
  • Testing Farm - CentOS Stream 9 - 1.22-micro[error]
  • Testing Farm - RHEL8 - 1.22-micro[error]
  • Testing Farm - RHEL8 - 1.24[error]
  • Testing Farm - RHEL8 - 1.22[error]
  • Testing Farm - CentOS Stream 9 - 1.26[error]
  • Testing Farm - RHEL10 - 1.26[error]
  • Testing Farm - RHEL10 - Unsubscribed host - 1.26[error]
  • Testing Farm - RHEL9 - 1.20[error]
  • Testing Farm - RHEL9 - 1.22[error]
  • Testing Farm - RHEL9 - Unsubscribed host - 1.22[error]
  • Testing Farm - RHEL9 - Unsubscribed host - 1.24[error]
  • Testing Farm - RHEL9 - Unsubscribed host - 1.26[error]
  • Testing Farm - RHEL9 - Unsubscribed host - 1.20[error]
  • Testing Farm - RHEL9 - 1.26[error]
  • Testing Farm - RHEL9 - 1.24[error]

🔴 Review - Missing review from a member (1 required)

Triggered by Workflow Run

@ndavidova
Copy link
Copy Markdown
Author

ndavidova commented May 18, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ndavidova ndavidova changed the title Ndavidov/distgen Onboard to distgen May 18, 2026
@ndavidova
Copy link
Copy Markdown
Author

ndavidova commented May 18, 2026

[test]

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - 1.26Fedora-latestx86_64❌ error18.05.2026 20:23:226min 23stest pipeline
CentOS Stream 9 - 1.26CentOS-Stream-9x86_64❌ error18.05.2026 20:23:2310min 5stest pipeline
CentOS Stream 10 - 1.26CentOS-Stream-10x86_64❌ error18.05.2026 20:23:239min 33stest pipeline
CentOS Stream 9 - 1.22-microCentOS-Stream-9x86_64❌ error18.05.2026 20:23:249min 45stest pipeline
CentOS Stream 9 - 1.24CentOS-Stream-9x86_64❌ error18.05.2026 20:23:228min 51stest pipeline
RHEL8 - 1.22RHEL-8.10.0-Nightlyx86_64❌ error18.05.2026 20:23:2211min 47stest pipeline
RHEL8 - 1.24RHEL-8.10.0-Nightlyx86_64❌ error18.05.2026 19:24:4611min 33stest pipeline
RHEL8 - 1.22-microRHEL-8.10.0-Nightlyx86_64❌ error18.05.2026 20:23:2211min 48stest pipeline
RHEL10 - 1.26RHEL-10.2-Nightlyx86_64❌ error18.05.2026 20:23:2214min 27stest pipeline
RHEL10 - Unsubscribed host - 1.26RHEL-10.2-Nightlyx86_64❌ error18.05.2026 20:23:2415min 30stest pipeline
RHEL9 - Unsubscribed host - 1.20RHEL-9.8.0-Nightlyx86_64❌ error18.05.2026 19:24:4316min 12stest pipeline
RHEL9 - 1.22RHEL-9.8.0-Nightlyx86_64❌ error18.05.2026 20:23:2317min 43stest pipeline
RHEL9 - 1.24RHEL-9.8.0-Nightlyx86_64❌ error18.05.2026 20:23:2217min 54stest pipeline
RHEL9 - Unsubscribed host - 1.22RHEL-9.8.0-Nightlyx86_64❌ error18.05.2026 19:24:3817min 18stest pipeline
RHEL9 - Unsubscribed host - 1.26RHEL-9.8.0-Nightlyx86_64❌ error18.05.2026 20:23:2316min 32stest pipeline
RHEL9 - 1.26RHEL-9.8.0-Nightlyx86_64❌ error18.05.2026 20:23:2217min 31stest pipeline
RHEL9 - 1.20RHEL-9.8.0-Nightlyx86_64❌ error18.05.2026 20:23:2317min 39stest pipeline
Fedora - PyTest - 1.26Fedora-latestx86_64❌ error18.05.2026 20:47:246min 5stest pipeline
CentOS Stream 10 - PyTest - 1.26CentOS-Stream-10x86_64❌ error18.05.2026 20:47:259min 23stest pipeline
CentOS Stream 9 - PyTest - 1.24CentOS-Stream-9x86_64❌ error18.05.2026 20:47:269min 54stest pipeline
CentOS Stream 9 - PyTest - 1.22-microCentOS-Stream-9x86_64❌ error18.05.2026 20:47:408min 44stest pipeline
CentOS Stream 9 - PyTest - 1.26CentOS-Stream-9x86_64❌ error18.05.2026 20:47:369min 25stest pipeline
RHEL8 - PyTest - 1.22RHEL-8.10.0-Nightlyx86_64❌ error18.05.2026 20:47:2412min 14stest pipeline
RHEL8 - PyTest - 1.24RHEL-8.10.0-Nightlyx86_64❌ error18.05.2026 20:47:2613min 11stest pipeline
RHEL8 - PyTest - 1.22-microRHEL-8.10.0-Nightlyx86_64❌ error18.05.2026 20:47:3812min 48stest pipeline
RHEL10 - PyTest - 1.26RHEL-10.2-Nightlyx86_64❌ error18.05.2026 20:47:2515min 24stest pipeline
RHEL10 - Unsubscribed host - PyTest - 1.26RHEL-10.2-Nightlyx86_64❌ error18.05.2026 20:47:2615min 19stest pipeline
RHEL9 - Unsubscribed host - PyTest - 1.26RHEL-9.8.0-Nightlyx86_64❌ error18.05.2026 20:47:2517min 54stest pipeline
RHEL9 - PyTest - 1.22RHEL-9.8.0-Nightlyx86_64❌ error18.05.2026 20:47:2418min 39stest pipeline
RHEL9 - Unsubscribed host - PyTest - 1.24RHEL-9.8.0-Nightlyx86_64❌ error18.05.2026 20:47:2418min 35stest pipeline
RHEL9 - PyTest - 1.26RHEL-9.8.0-Nightlyx86_64❌ error18.05.2026 20:47:2619min 32stest pipeline
RHEL9 - Unsubscribed host - PyTest - 1.22RHEL-9.8.0-Nightlyx86_64❌ error18.05.2026 20:47:3218min 31stest pipeline
RHEL9 - PyTest - 1.24RHEL-9.8.0-Nightlyx86_64❌ error18.05.2026 20:47:2420min 35stest pipeline

ndavidova added 2 commits May 18, 2026 21:45
@ndavidova
Fix empty RUN command in Dockerfile template
28b87ba 
Use Jinja2 conditional to handle empty environment_setup properly.
When environment_setup is empty (Fedora, C10S, RHEL10), generate
'RUN INSTALL_PKGS=...' instead of 'RUN \n    INSTALL_PKGS=...'
which caused build failures.
@ndavidova
Use JSON array format for CMD to suppress Docker warning
2adbe56 
Changed from 'CMD $STI_SCRIPTS_PATH/usage' to 'CMD ["/usr/libexec/s2i/usage"]'
to follow Docker best practices and prevent build warnings from breaking
image ID extraction in build scripts.
@ndavidova
Copy link
Copy Markdown
Author

ndavidova commented May 18, 2026

[test-pytest]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr/failing-ci pr/missing-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ndavidova