Skip to content

Support __pos__ magic method for Expr and GenExpr#1227

Merged
Joao-Dionisio merged 10 commits into
scipopt:masterfrom
Zeroto521:issue#1225
Jun 20, 2026
Merged

Support __pos__ magic method for Expr and GenExpr#1227
Joao-Dionisio merged 10 commits into
scipopt:masterfrom
Zeroto521:issue#1225

Conversation

@Zeroto521

Copy link
Copy Markdown
Contributor

Fix #1225

Comment thread tests/test_expr.py
@Zeroto521 Zeroto521 requested a review from Joao-Dionisio June 20, 2026 14:21
@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.22222% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.98%. Comparing base (9547994) to head (65fab37).

Files with missing lines Patch % Lines
src/pyscipopt/expr.pxi 73.52% 9 Missing ⚠️
src/pyscipopt/scip.pxi 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
+ Coverage   57.91%   57.98%   +0.07%     
==========================================
  Files          26       27       +1     
  Lines        5807     5839      +32     
==========================================
+ Hits         3363     3386      +23     
- Misses       2444     2453       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Joao-Dionisio

Copy link
Copy Markdown
Member

Thank you, @Zeroto521 !

@Joao-Dionisio Joao-Dionisio merged commit 7e2df02 into scipopt:master Jun 20, 2026
5 checks passed
jonathanberthias added a commit to jonathanberthias/PySCIPOpt that referenced this pull request Jun 20, 2026
@Zeroto521 Zeroto521 deleted the issue#1225 branch June 21, 2026 00:34
Joao-Dionisio pushed a commit that referenced this pull request Jun 21, 2026
* Add comprehensive type tests for expression arithmetic

* Add steps to stubs.yml workflow to check generated output

* Update mypy baseline after #1220

* Update tests and results after #1227

* Align dimensions of all arrays to 3

To avoid counting shape broadcasting errors as typing errors.
Since shape-typing is nearly impossible to achieve, let's
assume shapes are correct and focus on typing the operation
result.

* Ignore deb file in GH workflow

* Update baseline results

* Pin version of Mypy used

* Delete generated tests from repo

* Run test generation and baseline together

* Lock dependencies used

* Remove operations that always error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling + Variable will raise an TypeError.

2 participants