Drop goimports exception#262
Merged
Merged
Conversation
The pr261 repro previously needed a goimports exclusion in flake.nix because it had an unused 'sort' import that goimports would strip. Add a legitimate 'sort.Slice' reference so the import is used; the bare PkgName reference still triggers the original panic (without the visitor fix), and goimports leaves the file alone. The flake-level exception is no longer needed.
jupblb
changed the title
goimports exception by keeping its import usedgoimports exception
eseliger
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #261 added an exception in
flake.nixfor the pr261 repro because itsimport "sort"was unused andgoimportswould strip it (breaking the repro).Add a legitimate
sort.Slicereference alongside the barevar _ = sort. The legitimate use keepsgoimportshappy; the bare ident still tickles the originalshould never lookup PkgName ...assertion, so the test still fails without the visitor fix. The flake-level exception is no longer needed and is removed.