0.72.3 - Run Storybook tests before publishing on push to main#77
Merged
Conversation
The publish workflow runs on push to main but previously only ran Build before publishing. Storybook tests only ran on pull requests, so a merge to main could publish even if storybook tests would fail. Add a Storybook-Tests job to the publish workflow (build static Storybook + run the test-runner against it, matching the PR check) and make both publish jobs (GitHub Packages and NPMJS) depend on it in addition to Build.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jalexw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish workflow runs on push to main but previously only ran Build before publishing. Storybook tests only ran on pull requests, so a merge to main could publish even if storybook tests would fail.
Add a Storybook-Tests job to the publish workflow (build static Storybook + run the test-runner against it, matching the PR check) and make both publish jobs (GitHub Packages and NPMJS) depend on it in addition to Build.