Allow custom mail server URL in sendEmail function#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added support for overriding the mail server URL via an optional parameter in the
sendEmailfunction, while maintaining backward compatibility with the existing hardcoded domain resolution.Key Changes
sendEmailfunction to accept an optionalmailServerUrlparameter in the options objectmailServerUrlif supplied, otherwise fall back to the existinggetHardcodedApiServerDomain()resolutionImplementation Details
The change introduces a simple conditional check that prioritizes a custom mail server URL when provided via
opts.mailServerUrl. If not provided (or not a string), the function defaults to the original behavior of resolving the domain throughgetHardcodedApiServerDomain(). This maintains full backward compatibility while enabling flexibility for custom deployments or testing scenarios.https://claude.ai/code/session_01Hw6bDj3pwgRoUgj5dpLMo1