Add E2E test for non-org-member app deletion authorization#136
Merged
Conversation
…-member callers Adds NonOrgMemberCannotDeleteApp.cy.ts in the apps suite to exercise the "Only organization owners or global admins can delete apps" branch in DELETE_app_handler. Previously only the unauthenticated (401) and hardcoded-app (403) paths were covered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive E2E test coverage for the app deletion authorization check that prevents non-organization members from deleting apps, even when authenticated.
Changes
New test file:
tests/e2e-auth-tests/cypress/e2e/apps/NonOrgMemberCannotDeleteApp.cy.tsDELETE /api/apps/:app_idreturns 403 when the authenticated caller is neither a global admin nor a member of the app's owner organizationauth-server/src/app/api/apps/[app_id]/DELETE_app_handler.tsthat validatesisUserInOrganizationWithRole(..., "owner")Version bump:
tests/e2e-auth-tests/package.json(0.4.4 → 0.4.5)Implementation Details
misc/UnauthenticatedApiRequests.cy.tsresource_management/HardcodedResourceDeletionProtection.cy.tshttps://claude.ai/code/session_013GmrB4yjJDNFVmm7oTjTFW