Conversation
Package created: Name: odinControl Sub-directory: odinControl Signed-off-by: aujjwal-redhat <aujjwal@redhat.com>
rexe was defined in the outer module. Added sys to use the Rexe class. Signed-off-by: aujjwal-redhat <aujjwal@redhat.com>
sample => package docs=> docs for odinControl example=> the example folder tests => test cases Signed-off-by: aujjwal-redhat <aujjwal@redhat.com>
Added the commands that can help in running gluster from Source Code Signed-off-by: aujjwal-redhat <aujjwal@redhat.com>
| author='Srijan Sivakumar', | ||
| author_email='ssivakum@redhat.com', | ||
| license=license, | ||
| packages=['sample'], |
There was a problem hiding this comment.
I don't think the package name should be sample..
There was a problem hiding this comment.
packages tells the place where the package rexe is. In the refactored code I had put it in sample. Thats why I had added the refactored part to this PR only
Will close this PR then.
There was a problem hiding this comment.
By doing pip install . it was working on my system.
There was a problem hiding this comment.
I guess sample just says that you will find an init.py in this package.
There was a problem hiding this comment.
instead of doing the pip install . I'd say check the document as to how to use the test pypi environment and upload the package using twine and then install it in a virtualenv and see if the functionality works. Basically the package will be imported for it's class Rexe. So we need to check if that works.
There was a problem hiding this comment.
Also, on checking with the twine to see if the distribution is syntactically correct, I get errors for the operation wherein we read the license.
There was a problem hiding this comment.
instead of specifying the package, we can use the find_package() function provided by the setuptools module.
| @@ -0,0 +1 @@ | |||
| import rexe | |||
There was a problem hiding this comment.
did you try pushing the package to testpypi and try installing it from the created example pip package.. you can check the documentation : https://packaging.python.org/tutorials/packaging-projects/.
There was a problem hiding this comment.
ok will try it
example/comm_exec.yaml
Outdated
| @@ -0,0 +1,40 @@ | |||
| name: Command Execution | |||
There was a problem hiding this comment.
Please address this as a separate PR as this addresses a different issue
Will generate a new PR for this separately. Signed-off-by: aujjwal-redhat <aujjwal@redhat.com>
| author='Srijan Sivakumar', | ||
| author_email='ssivakum@redhat.com', | ||
| license=license, | ||
| packages=['sample'], |
There was a problem hiding this comment.
instead of specifying the package, we can use the find_package() function provided by the setuptools module.
2 participants
Package created:
Name: odinControl
Sub-directory: odinControl
Fix: #11
Signed-off-by: aujjwal-redhat aujjwal@redhat.com