Implementing Reset Passwords#2
Open
harshal017 wants to merge 1 commit into
Open
Conversation
|
|
||
| <properties> | ||
| <java.version>14</java.version> | ||
| <java.version>11</java.version> |
Collaborator
There was a problem hiding this comment.
Let's not have this in the PR.
| User user = userService.resetPassword(userDto); | ||
| return new ResponseDto<>( | ||
| HttpStatus.OK, | ||
| new UserResponseDto(user.getId(), user.getFullName(), user.getEmail(), user.isActive()) |
Collaborator
There was a problem hiding this comment.
Assume while logging in, person clicks on reset password. Then a new page opens that asks your email. So the only thing that will be sent in request will be the email ID of the person.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @Naman-Bhalla, I've tested the changes in my local and they are working as expected. Request you to try once at your end. Thanks