Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds the @retroactive attribute to Equatable protocol conformances for PlaybackTime and PlaybackPosition types to suppress Swift 6 compiler warnings about retroactive conformances. These types are C structs imported from the CSFBAudioEngine module that are being extended with protocol conformances in the Swift wrapper layer.
Changes:
- Added
@retroactivetoEquatableconformance forPlaybackTime - Added
@retroactivetoEquatableconformance forPlaybackPosition
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Sources/SFBAudioEngine/SFBPlaybackTime.swift | Adds @retroactive attribute to Equatable conformance for the imported PlaybackTime struct |
| Sources/SFBAudioEngine/SFBPlaybackPosition.swift | Adds @retroactive attribute to Equatable conformance for the imported PlaybackPosition struct |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sbooth
changed the title
retroactive to Equatable conformance to fix compiler warningsEquatable conformance
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sbooth
changed the title
Equatable conformanceEquatable conformance
This reverts commit b8d47cd.
By using the fully-qualified type names the warning is suppressed without the need for the
retroactiveattribute.