Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request renames the C++ namespace from CXXAudioHardware to audio_hardware to follow more conventional C++ naming conventions (lowercase with underscores). The change also updates all related include paths and converts Objective-C style #import directives to standard C++ #include directives.
Changes:
- Renamed namespace from
CXXAudioHardwaretoaudio_hardwareacross all header files, implementation files, and tests - Updated header include paths from
CXXAudioHardware/toaudio_hardware/in all files - Converted
#importdirectives to#includedirectives throughout the codebase - Reorganized include ordering to follow consistent pattern (project headers, system headers, standard library headers)
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/CXXAudioHardwareTests/CXXAudioHardwareTests.swift | Updated test to reference audio_hardware.CAAudioObject() instead of CXXAudioHardware.CAAudioObject() |
| Sources/CXXAudioHardware/include/module.modulemap | Updated header paths in module map from CXXAudioHardware/ to audio_hardware/ |
| Sources/CXXAudioHardware/include/audio_hardware/CAPropertyAddress.hpp | Changed namespace, converted #import to #include, and reordered includes |
| Sources/CXXAudioHardware/include/audio_hardware/CAAudioSystem.hpp | Changed namespace, updated internal include paths, and converted #import to #include |
| Sources/CXXAudioHardware/include/audio_hardware/CAAudioStream.hpp | Changed namespace, updated internal include paths, converted #import to #include, and reordered includes |
| Sources/CXXAudioHardware/include/audio_hardware/CAAudioObject.hpp | Changed namespace, updated internal include paths, converted #import to #include, and reordered includes |
| Sources/CXXAudioHardware/include/audio_hardware/CAAudioDevice.hpp | Changed namespace, updated internal include paths, and converted #import to #include |
| Sources/CXXAudioHardware/CAAudioObject.cpp | Updated implementation to use new namespace and include paths, converted #import to #include, and reordered includes |
| Sources/CXXAudioHardware/AudioHardwareErrors.hpp | Changed namespace, converted #import to #include, and reordered includes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.