Skip to content

Audio hardware namespace#9

Open
sbooth wants to merge 3 commits intomainfrom
audio_hardware-namespace
Open

Audio hardware namespace#9
sbooth wants to merge 3 commits intomainfrom
audio_hardware-namespace

Conversation

@sbooth
Copy link
Copy Markdown
Owner

@sbooth sbooth commented Jan 30, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 30, 2026 15:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request renames the C++ namespace from CXXAudioHardware to audio_hardware to follow more conventional C++ naming conventions (lowercase with underscores). The change also updates all related include paths and converts Objective-C style #import directives to standard C++ #include directives.

Changes:

  • Renamed namespace from CXXAudioHardware to audio_hardware across all header files, implementation files, and tests
  • Updated header include paths from CXXAudioHardware/ to audio_hardware/ in all files
  • Converted #import directives to #include directives throughout the codebase
  • Reorganized include ordering to follow consistent pattern (project headers, system headers, standard library headers)

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Tests/CXXAudioHardwareTests/CXXAudioHardwareTests.swift Updated test to reference audio_hardware.CAAudioObject() instead of CXXAudioHardware.CAAudioObject()
Sources/CXXAudioHardware/include/module.modulemap Updated header paths in module map from CXXAudioHardware/ to audio_hardware/
Sources/CXXAudioHardware/include/audio_hardware/CAPropertyAddress.hpp Changed namespace, converted #import to #include, and reordered includes
Sources/CXXAudioHardware/include/audio_hardware/CAAudioSystem.hpp Changed namespace, updated internal include paths, and converted #import to #include
Sources/CXXAudioHardware/include/audio_hardware/CAAudioStream.hpp Changed namespace, updated internal include paths, converted #import to #include, and reordered includes
Sources/CXXAudioHardware/include/audio_hardware/CAAudioObject.hpp Changed namespace, updated internal include paths, converted #import to #include, and reordered includes
Sources/CXXAudioHardware/include/audio_hardware/CAAudioDevice.hpp Changed namespace, updated internal include paths, and converted #import to #include
Sources/CXXAudioHardware/CAAudioObject.cpp Updated implementation to use new namespace and include paths, converted #import to #include, and reordered includes
Sources/CXXAudioHardware/AudioHardwareErrors.hpp Changed namespace, converted #import to #include, and reordered includes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants