feat: standardize Kueue config and restore trace propagation#15
Merged
Merged
Conversation
Align Kueue Helm config with syft-generator. Move ResourceFlavor to sbomer-platform. Restore manual trace context propagation in TaskReconciler.
thavlice
reviewed
Apr 29, 2026
| ObjectMapper objectMapper; | ||
|
|
||
| @Inject | ||
| Tracer tracer; |
Contributor
There was a problem hiding this comment.
Out of curiosity, what is the difference in using Tracer vs using the @WithSpan?
Member
Author
There was a problem hiding this comment.
Basically if we just rely on @WithSpan we end up with an orphaned TaskReconciler root span because TaskReconciler is triggered by an async Kubernetes event - it has no knowledge of the parent span. It would end up disconnected to the generation request that triggered it and become part of a new trace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align Kueue Helm config with syft-generator.
Move ResourceFlavor to sbomer-platform.
Restore manual trace context propagation in TaskReconciler.