Skip to content

feat: replace in-memory scheduling with Kueue#14

Merged
thavlice merged 3 commits into
sbomer-project:mainfrom
thavlice:kueue-adaptation
Apr 27, 2026
Merged

feat: replace in-memory scheduling with Kueue#14
thavlice merged 3 commits into
sbomer-project:mainfrom
thavlice:kueue-adaptation

Conversation

@thavlice
Copy link
Copy Markdown
Contributor

Replaced in memory scheduling and cluster resource management with Kueue management. Needs Kueue installed in the cluster.

Replaced in memory scheduling and cluster resource management
with Kueue management. Needs Kueue installed in the cluster.
Copy link
Copy Markdown
Collaborator

@mertbugrabicak mertbugrabicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty nice! Just added some requests to make it more configurable through helm, and just had some questions to confirm how stuff works. But the state of this looks great I think if we can strip out so much of the complexity like this and just give it to Kueue to manage

Comment thread helm/java-generator-chart/templates/kueue/clusterqueue.yaml
Comment thread src/main/resources/application.properties
@thavlice thavlice requested a review from mertbugrabicak April 27, 2026 09:23
Copy link
Copy Markdown
Collaborator

@mertbugrabicak mertbugrabicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM!

@thavlice thavlice merged commit 16cc338 into sbomer-project:main Apr 27, 2026
1 check passed
@thavlice thavlice deleted the kueue-adaptation branch April 27, 2026 11:29
apiVersion: kueue.x-k8s.io/v1beta1
kind: ResourceFlavor
metadata:
name: {{ .Values.kueue.resourceFlavor.name }}
Copy link
Copy Markdown
Member

@tecarter94 tecarter94 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thavlice I'm having issues deploying the latest sbomer-platform on IBM Cloud because both this generator and syft-generator try to manage a ResourceFlavor named "default-flavor". I'm thinking we should define this once in sbomer-platform - assuming it's supposed to be shared.

Copy link
Copy Markdown
Contributor Author

@thavlice thavlice Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tecarter94 Agree, lets create the ResourceFlavor in the sbomer-platform and probably have under feature flag in the generators or not have it at all. We can set it up wherever, from functionality perspective it won't matter for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants