feat: replace in-memory scheduling with Kueue#14
Conversation
Replaced in memory scheduling and cluster resource management with Kueue management. Needs Kueue installed in the cluster.
24424c0 to
4d2c19f
Compare
mertbugrabicak
left a comment
There was a problem hiding this comment.
Pretty nice! Just added some requests to make it more configurable through helm, and just had some questions to confirm how stuff works. But the state of this looks great I think if we can strip out so much of the complexity like this and just give it to Kueue to manage
mertbugrabicak
left a comment
There was a problem hiding this comment.
Thanks for the changes, LGTM!
| apiVersion: kueue.x-k8s.io/v1beta1 | ||
| kind: ResourceFlavor | ||
| metadata: | ||
| name: {{ .Values.kueue.resourceFlavor.name }} |
There was a problem hiding this comment.
@thavlice I'm having issues deploying the latest sbomer-platform on IBM Cloud because both this generator and syft-generator try to manage a ResourceFlavor named "default-flavor". I'm thinking we should define this once in sbomer-platform - assuming it's supposed to be shared.
There was a problem hiding this comment.
@tecarter94 Agree, lets create the ResourceFlavor in the sbomer-platform and probably have under feature flag in the generators or not have it at all. We can set it up wherever, from functionality perspective it won't matter for now.
Replaced in memory scheduling and cluster resource management with Kueue management. Needs Kueue installed in the cluster.