Skip to content

Comments

linter: warn about foreign key constraints in create table defs#945

Merged
kodiakhq[bot] merged 2 commits intomasterfrom
steved-warn-fk-in-create-table
Feb 21, 2026
Merged

linter: warn about foreign key constraints in create table defs#945
kodiakhq[bot] merged 2 commits intomasterfrom
steved-warn-fk-in-create-table

Conversation

@sbdchd
Copy link
Owner

@sbdchd sbdchd commented Feb 21, 2026

we still need to take locks on the related table: https://squawkhq.com/docs/adding-foreign-key-constraint

Adding a foreign key constraint requires a table scan and a SHARE ROW EXCLUSIVE lock on both tables, which blocks writes to each table.

rel: #938
rel: #220

@sbdchd sbdchd added the automerge automerge with kodiak label Feb 21, 2026
@kodiakhq kodiakhq bot merged commit c791ae3 into master Feb 21, 2026
30 of 32 checks passed
@kodiakhq kodiakhq bot deleted the steved-warn-fk-in-create-table branch February 21, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge automerge with kodiak

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant