fix(x11): use xclip for persistent clipboard ownership#362
Open
Sraq-Zit wants to merge 2 commits into
Open
Conversation
In X11, the owning process must stay alive to serve SelectionRequest events. The previous native implementation held ownership for only 1 second before exiting, causing the clipboard to appear empty to other apps after the TUI closed. - Use xclip to copy text/images so ownership persists after TUI closes - Check TARGETS atom before requesting image data to avoid xclip returning garbage bytes for unsupported formats `xclip` must be installed for X11 clipboard to work correctly. `xsel` could be impelmented the same way too except for images which are unsupported
Sraq-Zit
force-pushed
the
fix/x11-clipboard-persistence
branch
from
f8bf1ff to
1aca5ba
Compare
…parent terminal lifetime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In X11, the owning process must stay alive to serve SelectionRequest events. The previous native implementation held ownership for only 1 second before exiting, causing the clipboard to appear empty to other apps after the TUI closed.
Fixes #45
Changes
Notes
xclipmust be installed for X11 clipboard to work correctly.xselcould be impelmented the same way too except for images which are unsupported