feat(search): add fzf engine with frecency tiebreak#359
Open
luizhcrocha wants to merge 2 commits into
Open
Conversation
feat(search): add fzf engine with frecency tiebreak chore(Makefile): fix formatting and syntax errors
Author
|
After some usage... i think it's not quite there yet. Will mark as draft and try to improve and fix some problems. |
91c7492 to
e3fa456
Compare
Author
|
Now i think it's quite nice. Added a way to quantize better so tiebreaks works more 'loosely', and let other tiebreak steps resolve close calls. Fixed a bug with unsafe code, a bad usage of fzf Slab, and, I think most importantly, and need review, is that:
|
e3fa456 to
54b746f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, @savedra1
I've made this to give users an option on search engine and search result optimization, so they can get the most out of the search feature, tweaking as they like.
The default is still
charmbracelet/bubblesbacked bysahilm/fuzzy, but if the user want's he can choose to usejunegunn/fzfby adding these to settings:{ "search": { "engine": "fzf", "algo": "v2", "caseSensitivity": "smart", "normalize": true, "tiebreak": ["score", "frecency", "index"] } }One thing that I think you might not like is that I changed
func sanitizedFilterto a high-order functionfunc buildFilter, because I thought that would make the code more concise.Wrote with Claude Code help, not full on vibecoded (I know some people hate this). Test was all Claude Code though.