fix: disk space checks and storage path validation #348#349
Open
Dziksonn wants to merge 3 commits into
Open
Conversation
Author
|
Whoops I commited flake.nix by mistake too, my bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have any experience with Go, I tried my best, treat it more as of proof of concept how #348 could be fixed/or what could be causing issues.
While trying to fix it I also spotted that "/" is always used, instead of config values (I created limited size folder in mnt for testing purpose and I ran into it) so I added ability to check config path instead. My approach definitely can be improved, just didn't want to mess too much with your code.