This repository was archived by the owner on Oct 24, 2025. It is now read-only.
Use Minitest module instead of MiniTest compatibility layer#242
Open
oturpe wants to merge 2 commits intosass:masterfrom
Open
Use Minitest module instead of MiniTest compatibility layer#242oturpe wants to merge 2 commits intosass:masterfrom
oturpe wants to merge 2 commits intosass:masterfrom
Conversation
The Minitest package has long been capitalized like that. The variant MiniTest is retained only as a compatibility layer. Switch to the current module name. This change is motivated by Fedora, which already uses minitest 5.19. That version requires setting the env variable MT_COMPAT to import the compatibility module, and thus revealed the problem in Fedora build system. Signed-off-by: Otto Liljalaakso <otto.liljalaakso@iki.fi>
sassc-ruby build in Fedora ignores the dependency version constaints given in gemspec and uses the versions included in the Fedora distribution. Currently, Fedora is on 5.19.0, which works. Based on this, the version constaint can be considerably relaxed. Signed-off-by: Otto Liljalaakso <otto.liljalaakso@iki.fi>
|
Hi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Minitest package has long been capitalized like that. The variant
MiniTest is retained only as a compatibility layer. Switch to the
current module name.
This change is motivated by Fedora, which already uses minitest 5.19.
That version requires setting the env variable MT_COMPAT to import the
compatibility module, and thus revealed the problem in Fedora build
system.