Github action to update version number inside Ada script#131
Conversation
Because I need to check if the version update works
Adding the commit hash to the version number was a bad idea, because all the time the remote has a commit extra compared to your local branch. Then you get the error: "Updates were rejected because the remote contains work that you do not have locally." You can solve that by doing git push --force, but it's not very convenience (and probably not quite safe) to do that with every push.
|
This is a bit difficult to follow, because some of the changes were already directly incorporated in master. Now there is update-version-file.yml and Update-ada-version.yml, should both be used? And there is the file ada-version, should this be removed by this PR? |
|
Hi Haili, apologies for the mess. I'm new to Github actions. If you agree with this PR, we can remove |
They are from a previous effort to automate version info
hailihu
left a comment
hailihu
left a comment
There was a problem hiding this comment.
I think this is a nice solution for automatic versioning. Just a few comments.
No problem, just wanted to be sure I understand what is happening. |
* Renamed Update-ada-version.yml to update-ada-version.yml, because existing actions don't have capitals in their name either * Changed sed command to be more compatible with MacOS: sed -i expression file -> sed expression -i file
…ment unnecessary. Thanks Haili for reading the documentation :-)
2 participants
Fixes #123
Adding action Update-ada-version.yml that updates the value of ADA_VERSION in the script ada/ada
After creating a new branch, the version is set to the branch name. This will be a separate commit in Github. You may need to pull this commit before pushing changes to that branch, otherwise you may get "Updates were rejected because the remote contains work that you do not have locally".
If you create a branch in Github and then check it out locally, things should be OK.