Skip to content

Conversation

@a-hurst
Copy link
Collaborator

@a-hurst a-hurst commented Aug 3, 2021

PR Description

This PR removes a bunch of unnecessary conversions back and forth between Volts and mV, likewise changing the units for a few user-facing EEG attributes (e.g. self.EEG_before_interpolation) in PrepPipeline from the EEGLAB standard of mV to the MNE standard of volts.

This should make the API less confusing for people used to working in the MNE world, avoid a bunch of unnecessary large matrix multiplication, and makes some other proposed API changes in #99 easier to implement.

Merge Checklist

  • the PR has been reviewed and all comments are resolved
  • all CI checks pass
  • (if applicable): the PR description includes the phrase closes #<issue-number> to automatically close an issue
  • (if applicable): bug fixes, new features, or API changes are documented in whats_new.rst

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.04%. Comparing base (7ad292c) to head (8fe116a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   99.04%   99.04%   -0.01%     
==========================================
  Files           7        7              
  Lines         736      734       -2     
==========================================
- Hits          729      727       -2     
  Misses          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sappelhoff sappelhoff merged commit ec44384 into sappelhoff:master Aug 4, 2021
@sappelhoff
Copy link
Owner

Thanks @a-hurst!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants