Added support for image rotation and enhanced some features#9
Open
jmalarcon wants to merge 33 commits into
Open
Added support for image rotation and enhanced some features#9jmalarcon wants to merge 33 commits into
jmalarcon wants to merge 33 commits into
Conversation
…o saplumbaga-master
Updated npm dependencies
- Allow zooming elements with several images inside
2. Extend loading duration for UI improvements
Dynamically add pan to new loaded images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Samil:
I've enhanced the plugin with several features:
[NEW]Image rotation support, using transforms for rotation and pan position. This removes support for IE versions before 10. (IE10+ supported with jQuery 1.x).[Enhancement]New icons. The original zoom in, zoom out and close icons were not easily spotted with very dark or very light big images (not enough contrast). I've added a subtle glow effect and changed the color slightly, and they are now very easily spotted under most circumstances.[Enhancement]Added support for an animated loading indicator that is shown while the big image loads. Yo had that in mind but was not implemented.[Bug]Fixed a bug: When a new image was loaded the previous zoomed one was shown while the new loaded. Now the previous one is unloaded before the new starts to load and the progress indicator is shown.Hope you like at and merge my changes with yours.
Best regards