Fixed critical bugs: HTML escaping, email configuration, and type checking #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tements in html_escape function so that ampersand replacement happens last, preventing double-escaping.
…hecking BUG sansan0#2-4: Added type conversion for email_smtp_port from string to integer with null checking before conversion. Fixed unsafe dictionary access. BUG sansan0#5-6: Added type checking in matches_word_groups() function for filter_word, req_word, and normal_word to prevent AttributeError when calling .lower() on non-string types. Fixes ValueError, TypeError, and AttributeError exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes 6 critical bugs in the main.py file:
BUG 1: HTML Escaping Order
Fix: Reordered replace() statements in html_escape() function
Issue: Ampersand replacement was happening before other HTML entities, causing double-escaping
-impact: Prevents unintended HTML entity duplication
BUG 2-4: Email Configuration and Type Conversion
-Fix: Added type conversion for email_smtp_port from string to integer with null checking
BUG 5-6: Type Checking in matches_word_groups()
Fix: Added isinstance() checks for filter_word, req_word, and normal_word
Issue: String methods like .lower() were called without verifying type
Impact: Prevents AttributeError when non-string types are passed
Testing
All changes maintain backward compatibility and preserve existing functionality. i hope it helps