fix: resolve TypeScript build error in notifyMail SMTP transporter#63
Merged
Conversation
|
✅ PR Validation Passed Your PR title and description meet all requirements:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a TypeScript compilation error introduced when adding Railway-specific SMTP options
(
family,connectionTimeout, etc.) to the Nodemailer transporter. Thefamily: 4property is not present in Nodemailer's default
TransportOptionstype, causing the buildto fail with a "No overload matches this call" error.
Related issue
Fixes #62
Changes
import type SMTPTransport from "nodemailer/lib/smtp-transport"inlib/notifyMail.tscreateTransport(...)options object asSMTPTransport.Optionsto satisfy TypeScriptwhile preserving all runtime SMTP settings (
family: 4, timeouts, TLS config)Testing
npm run buildcompletes successfully with no TypeScript errorsChecklist
Fixes #62