Y26-062 Bioscan - modified presenter to require active submission to show PCR 1 create button#2739
Open
andrewsparkes wants to merge 2 commits intodevelopfrom
Open
Y26-062 Bioscan - modified presenter to require active submission to show PCR 1 create button#2739andrewsparkes wants to merge 2 commits intodevelopfrom
andrewsparkes wants to merge 2 commits intodevelopfrom
Conversation
…how child PCR 1 button unless there is an active library prep request
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2739 +/- ##
===========================================
+ Coverage 84.93% 84.94% +0.01%
===========================================
Files 501 502 +1
Lines 20598 20610 +12
Branches 377 377
===========================================
+ Hits 17495 17508 +13
+ Misses 3100 3099 -1
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2727
Changes proposed in this pull request
Modifies presenter so that when there's a repeat library prep from a lysate plate there must be an active submission first for button to show.
See int suite PR
https://gitlab.internal.sanger.ac.uk/psd/integration-suite/-/merge_requests/306