[FEAT] 인성 면접 기능 추가#361
Conversation
|
Warning Review limit reached
More reviews will be available in 34 minutes and 23 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
Walkthrough
Changes인성 면접 타입 추가
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 본 PR은 사용자의 소프트 스킬과 가치관을 평가할 수 있는 '인성 면접' 기능을 시스템에 도입합니다. 기존 기술 면접 중심의 인터뷰 시스템을 확장하여, 인성 면접에 특화된 프롬프트와 평가 로직을 구축하고 관련 서비스 및 데이터베이스 구조를 개선하였습니다. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. 코드의 논리 너머로, 사람의 마음을 묻는다. 가치관과 태도 속에, 진정한 성장을 담아, 새로운 면접이 시작된다. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'PERSONALITY' (인성 면접) interview category and type to support personality-based interviews. The changes include updates to domain enums, database schema migration, new GPT and Bedrock system prompts tailored for personality evaluations, and integration within the interview start and message factories, accompanied by comprehensive tests. The review feedback correctly points out that the migration file V50__add_personality_category_and_seed.sql is missing the actual seed data (INSERT statements) implied by its name, which is required for the feature to function properly.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Test Results 55 files 55 suites 1m 52s ⏱️ Results for commit 90a371e. ♻️ This comment has been updated with latest results. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/resources/db/migration/V50__add_personality_category_and_seed.sql`:
- Around line 1-13: The V50 migration only extends the root_question.category
enum to include PERSONALITY, but it does not seed any active PERSONALITY root
question, leaving fresh deployments without data for that flow. Update the
migration strategy around the root_question seed so that at least one active
Category.PERSONALITY root question is inserted, either in this migration or an
immediately following seed migration, and make sure the seed uses the same root
question data path referenced by the existing root_question setup.
In
`@src/test/java/com/samhap/kokomen/interview/controller/InterviewControllerV2Test.java`:
- Around line 118-156: The PERSONALITY V2 controller test currently verifies the
flow but does not generate RestDocs, so the scenario is missing from the
documentation output. Update the `인성_면접도_V2_진행_파이프라인을_예외_없이_통과한다` test to
include the same `MockMvc` documentation step used by other controller tests by
chaining `andDo(document(...))` on the `mockMvc.perform(...)` call. Keep the
rest of the integration-style setup intact so this test continues to exercise
the real `InterviewControllerV2` pipeline while producing RestDocs.
In
`@src/test/java/com/samhap/kokomen/interview/external/dto/request/InterviewBedrockRequestFactoryTest.java`:
- Around line 42-70: The test coverage in InterviewBedrockRequestFactoryTest
only checks the new PERSONALITY branch, so add an assertion for the RESUME_BASED
branch to ensure it still follows the existing default prompt path. Reuse the
existing helper calls around InterviewBedrockRequestFactory.createProceedSystem,
createEndSystem, or createAnswerFeedbackSystem and verify RESUME_BASED matches
the CATEGORY_BASED prompt behavior for at least one representative case. This
will protect the switch expansion logic without changing the current
PERSONALITY-specific assertions.
In
`@src/test/java/com/samhap/kokomen/interview/tool/InterviewMessagesFactoryTest.java`:
- Around line 140-174: `InterviewMessagesFactory`의 `createGptProceedMessages`와
`createGptEndMessages`는 `switch` 분기 변경이 있었지만 현재 테스트는 `PERSONALITY`만 검증합니다.
`InterviewMessagesFactoryTest`에 `RESUME_BASED` 케이스를 추가해 두 메서드가 기본 이력서용 시스템 프롬프트를
사용하는지 각각 확인하도록 하세요. `InterviewType.RESUME_BASED`, `GptSystemMessageConstant`,
`createGptProceedMessages`, `createGptEndMessages`를 기준으로 찾아서 테스트를 보강하면 됩니다.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 20796d89-a790-4316-823e-eb8261075f36
📒 Files selected for processing (19)
src/main/java/com/samhap/kokomen/category/domain/Category.javasrc/main/java/com/samhap/kokomen/interview/domain/Interview.javasrc/main/java/com/samhap/kokomen/interview/domain/InterviewType.javasrc/main/java/com/samhap/kokomen/interview/domain/RootQuestion.javasrc/main/java/com/samhap/kokomen/interview/external/dto/request/InterviewBedrockRequestFactory.javasrc/main/java/com/samhap/kokomen/interview/repository/RootQuestionRepository.javasrc/main/java/com/samhap/kokomen/interview/service/InterviewStartFacadeService.javasrc/main/java/com/samhap/kokomen/interview/service/question/RootQuestionService.javasrc/main/java/com/samhap/kokomen/interview/tool/GptSystemMessageConstant.javasrc/main/java/com/samhap/kokomen/interview/tool/InterviewMessagesFactory.javasrc/main/java/com/samhap/kokomen/interview/tool/PersonalityInterviewBedrockSystemMessageConstant.javasrc/main/java/com/samhap/kokomen/interview/tool/PersonalityInterviewPromptFragments.javasrc/main/resources/db/migration/V50__add_personality_category_and_seed.sqlsrc/test/java/com/samhap/kokomen/category/controller/CategoryControllerTest.javasrc/test/java/com/samhap/kokomen/interview/controller/InterviewControllerV2Test.javasrc/test/java/com/samhap/kokomen/interview/external/dto/request/InterviewBedrockRequestFactoryTest.javasrc/test/java/com/samhap/kokomen/interview/service/PersonalityInterviewServiceTest.javasrc/test/java/com/samhap/kokomen/interview/service/question/RootQuestionServiceTest.javasrc/test/java/com/samhap/kokomen/interview/tool/InterviewMessagesFactoryTest.java
1 participant
closed #
작업 내용
스크린샷
참고 사항