Conversation
samcday
left a comment
There was a problem hiding this comment.
Hey I'm feeling like we should extend/bastardize the alpine build here as well to also produce x86 + aarch64 musl binaries for binstall.
.github/workflows/release.yml
Outdated
| - name: Build release archive | ||
| run: | | ||
| set -euo pipefail | ||
| rustup toolchain install stable --profile minimal | ||
| rustup default stable | ||
| cargo build --release | ||
| mkdir -p dist/ | ||
| tar -C target/release -czf "dist/phrog-x86_64-unknown-linux-gnu.tar.gz" phrog |
There was a problem hiding this comment.
Let's move this whole step out. We've already got the pattern in place to upload artifacts to the release from the other jobs/pipelines.
So let's add a release-builds.yaml, and make it a matrix build that includes a variant on Github's official arm64 runner, so that way we produce both x86_64-unknown-linux-gnu and aarch64-unknown-linux-gnu builds.
.github/workflows/release.yml
Outdated
| files: | | ||
| dist/phrog-x86_64-unknown-linux-gnu.tar.gz |
There was a problem hiding this comment.
This should go away when the release-builds.yaml pipeline is introduced.
|
@codex address the feedback and update the PR |
Summary
Testing
Also completed follow-up actions requested:
|
Codex Task