feat(clmm): improve swap/burn UX and fix CI#4
Merged
Conversation
Align verifier calldata, contracts config, and seed script with latest Sepolia deployment. Made-with: Cursor
Return concrete amounts from ASP, use placeholder notes and sync to confirmed values so shielded swaps/burns remain consistent across crashes and restarts. Made-with: Cursor
Add safe CLMM swap output estimation, show expected amounts on swap and burn flows, and align default ticks with current pool state. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…wap-improvements # Conflicts: # asp/src/api/routes.rs # asp/src/sync/events.rs # sdk/test/operations/deposit.test.ts
salazarsebas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ASP (Rust)
amount_out/amount_changein swap and burn responsessync/events.rs(unused selectors and structs)as u128,as u32,u128::from)last_rootunused-assignment warnings in mint/swap handlers.contains()in validationtower_governorimportsSDK (TypeScript)
amount_out,amount_change,syncCommitments)DepositResultinterfaceTICK_OFFSETin position commitment testFrontend
@/lib/utilsimport →@/lib/cninSkeleton.tsxDeploy
Test plan
cargo clippy -- -D warningspasses with 0 errorsbun testin SDK: 107/107 passingtsc --noEmitin frontend: clean