feat: better approach to client resource management#11
Merged
Conversation
sgbalogh
commented
Feb 12, 2025
| withSourcesJar() | ||
| toolchain { | ||
| languageVersion.set(JavaLanguageVersion.of(17)) | ||
| languageVersion.set(JavaLanguageVersion.of(19)) |
Member
Author
There was a problem hiding this comment.
scheduled executor only impl's AutoClosable starting in 19, so the bump is required (just for the demo, not SDK)
Contributor
|
@sgbalogh yeah, I think I like this way better. I think I got bogged down in closing the previous channel and managing all the edge cases, this is much cleaner, also more idiomatic I think for these kinds of clients. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoClosablebut only shutdown owned resources (executor, grpc channel)ManagedChannelFactory, to expose simple util for constructing a channel given an s2 configManagedChannelthat implementsAutoClosable(only now can I see @ASRagab's wisdom in the original ChannelManager 😛, whoops )ManagedReadSessionandManagedAppendSessionalso now implAutoClosableI think this is a more reasonable approach to dealing with these resources?