Add support for named trackers (Google Tag Manager)#7
Open
erikwiffin wants to merge 2 commits intoryanto:masterfrom
erikwiffin:master
Open
Add support for named trackers (Google Tag Manager)#7erikwiffin wants to merge 2 commits intoryanto:masterfrom erikwiffin:master
erikwiffin wants to merge 2 commits intoryanto:masterfrom
erikwiffin:master
Conversation
Owner
|
This looks good, but I need tests before I can merge it. |
|
Any update on this? |
Owner
|
Looks good but it needs tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google Tag Manager doesn't use the default tracker, so "send" calls need to be prefixed with the tracker id.
This change uses the first tracker if multiple trackers are defined, or no prefix otherwise. This should be sufficient for any standard Google Tag Manager install.
https://groups.google.com/forum/#!topic/google-analytics-analyticsjs/mayu2cf1d0k
https://developers.google.com/analytics/devguides/collection/analyticsjs/advanced#multipletrackers