use gem dotenv#4
Open
tylersloan wants to merge 3 commits into
Open
Conversation
ryanmccrary
requested changes
Nov 4, 2016
Owner
ryanmccrary
left a comment
ryanmccrary
left a comment
There was a problem hiding this comment.
I just saw this for some reason (I'm getting ready for Christmas this year)
I love these changes.
It wont let me edit before merging - but the only thing I would say to change would be to put
gem 'dotenv-rails'
in the development group of the gemfile so it doesn't break any production setups that are already being used. We set our ENV variables through heroku typically.
Thoughts?
chandlervdw
reviewed
Nov 4, 2016
| <script src="https://checkout.stripe.com/checkout.js"></script> | ||
| <meta property="og:image" content="http://christmas.goattrips.org/img/400x400.jpg" /> | ||
| <meta property="og:image:secure_url" content="https://christmas.goattrips.org/img/400x400.jpg" /> | ||
| <meta property="og:description" content="I participated in GOAT Christmas and you should too! If one person gives each of the values below from $1-200 we will raise just over $20,000 to kickstart our programs for 2015. GOAT would never happen without passionate people giving generously to changing lives in Greenville." /> |
Collaborator
There was a problem hiding this comment.
should say "dickstart" our programs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow you to store your secret keys, etc, in an ignored file and not have to worry about them while developing locally anymore.
Also updated Ruby version to be compatible with Heroku's Cedar-14 Stack.