Add pre-command check for .elm-spa folder for commands other than new/init/help#157
Open
JonLatane wants to merge 3 commits into
Open
Add pre-command check for .elm-spa folder for commands other than new/init/help#157JonLatane wants to merge 3 commits into
JonLatane wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No idea if this actually works - some hand-holding through testing would be helpful (I'm new to this type of FE build system stuff). You should absolutely not merge this blind!
Hopefully the intent of the code is pretty clear; I'm annoyed at
.elm-spaandsrcdirectories when I accidentallyelm-spa addor whatever in the wrong directory (any directory other than the root of my project, where the.elm-spafolder is). The intent is to check for.elm-spaanytime a command other thanelm-spa initorelm-spa helpis run, to eliminate this footgun since I'm a developer prone to shooting myself in the foot 😄