fix: message bumpy issue#49
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts chat scroll/pinning behavior to reduce “bumpy” motion by controlling when scroll-to-top animations run and by coalescing bottom-follow scrolling during streaming/content growth.
Changes:
- Added an
animatedflag to “pin sent message to top” so initial pin can animate while subsequent re-pins can be non-animated. - Changed desktop
MessageListViewbottom-follow behavior to coalesce scroll-to-bottom calls (rate-limited) and avoid fighting layout during streaming. - Improved desktop “release pinned turn” detection by distinguishing direct user drags from inertial/decelerating phases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| RxCodeMobile/Views/MobileChatView.swift | Adds an animated parameter to top-pinning to reduce scroll jitter during layout/keyboard changes. |
| Packages/Sources/RxCodeChatKit/MessageListView.swift | Coalesces bottom-follow scrolling, tracks max measured turn height to stabilize spacer sizing, and refines user-scroll detection for releasing top-pin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+444
to
+449
| let delayNanoseconds = UInt64(delay * 1_000_000_000) | ||
| if delayNanoseconds > 0 { | ||
| try? await Task.sleep(nanoseconds: delayNanoseconds) | ||
| } | ||
| guard !Task.isCancelled else { return } | ||
| scrollTask = nil |
Contributor
Author
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.